Fix enable_internal_pullup to always use pull-ups#13
Merged
UncleRus merged 1 commit intoesp-idf-lib:mainfrom Mar 11, 2026
Merged
Fix enable_internal_pullup to always use pull-ups#13UncleRus merged 1 commit intoesp-idf-lib:mainfrom
UncleRus merged 1 commit intoesp-idf-lib:mainfrom
Conversation
cleishm
force-pushed
the
fix-internal-pullup-direction
branch
from
7d4653d to
2462b86
Compare
Contributor
Author
|
Note that I chose not to try and support any kind of pulldown through the API (even when |
cleishm
force-pushed
the
fix-internal-pullup-direction
branch
from
2462b86 to
5f3ad45
Compare
Previously, the pull direction was based on btn_pressed_level, which caused pull-downs to be applied to encoder pins when btn_pressed_level was 1. Encoder pins always need pull-ups since they are wired with common to ground. Now always uses pull-ups and documents that the button pin may need a separate pull-down when btn_pressed_level is 1. Fixes esp-idf-lib#12
cleishm
force-pushed
the
fix-internal-pullup-direction
branch
from
5f3ad45 to
8c8d7d2
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_internal_pullupto always enable pull-up resistors, as encoder pins need pull-ups since they are wired with common to groundenable_internal_pullupis false, leave pull resistors unchanged instead of explicitly disabling them, so users can pre-configure pulls viagpio_set_pull_mode()before creating the encodergpio_set_pull_mode()) whenbtn_pressed_levelis 1Fixes #12