Fix flip-link, make SSP configurable#3203
Merged
MabezDev merged 8 commits intoesp-rs:mainfrom Mar 5, 2025
Merged
Conversation
bugadani
force-pushed
the
flip-link
branch
3 times, most recently
from
9a8a1c5 to
b23b6f2
Compare
MabezDev
requested changes
Mar 5, 2025
bjoernQ
approved these changes
Mar 5, 2025
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
Looking forward to rebase 3124 on this some day
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a reproducer showing that flip-link does not work. I've also tried a freshly generated project, and it also doesn't work. So it's time to add a test.
I had to modify
config.tomla bit to get this to fail, but that should be okay because our template says the following:I've ran the
wifi_embassy_access_point_with_staexample on both S3 and C6 (with and without flip_link) and all three tests were successful.Closes #3213