Misleading error: "Invalid GitHub token" whenever query fails

[wrsturgeon]

Initially, I had the same problem as this closed issue. I left a few comments there before I realized it was closed, so let me summarize here:

It seems like XtensaRust::get_latest_version() is failing. However, this line seems to delete errors received from XtensaRust::get_latest_version() and return Error::GithubTokenInvalid instead (a bit misleading, since GithubTokenInvalid is also returned later in the file for an explicit authorization error). Because the original errors are suppressed, it's difficult for me to give you exactly what's going wrong, but I believe I've tracked it down to the function github_query by observing which log::debug! statements are printed before the program exits.

So, I guess this error is two-fold:

1. Is there a way to uncover the real error and work around it?
2. Is it possible to provide a more informative error message on the above line? I'd be willing to help out as well.

Thanks for anything that might help!

Best,
Will

[SergioGasquez]

Hi! Thanks for opening the issue and the details, mind trying (#496) https://github.com/SergioGasquez/espup/tree/fix/latest-version?

[wrsturgeon]

Thanks for writing that up so quickly!

OK, interesting developments. I've been using Nix to manage Rust & Cargo, so I have rustc and cargo in PATH, but not rustup. Because of that, the first error I got was "Rust is not installed" (espup::toolchain::rust::missing_rust), which is raised exclusively by check_rust_installation, which in turn is called exclusively by install here--but it's called after a debug message that didn't print before. Before fully installing, let me go back to the original espup and see if I get the same error, or if some networking error cleared itself up.

Thanks again for your help, and be back in a sec!

[wrsturgeon]

OK, here's the output with RUST_LOG=debug on upstream espup, installed with cargo binstall espup:

...
[debug]: Chunked body in response
[debug]: response 200 to GET https://crates.io/api/v1/crates/espup/versions
[debug]: dropping stream: Stream(RustlsStream)
[info]: Installing the Espressif Rust ecosystem
[debug]: Querying GitHub API: 'https://api.github.com/repos/esp-rs/rust-build/releases/latest'
[debug]: starting new connection: https://api.github.com/
[debug]: starting new connection: https://api.github.com/
[debug]: starting new connection: https://api.github.com/
[debug]: starting new connection: https://api.github.com/
[debug]: starting new connection: https://api.github.com/
[debug]: starting new connection: https://api.github.com/
Error: espup::toolchain::rust::query_github

  × Failed to query GitHub API: Invalid Github token

And on your fork with a fake rustup in path:

...
[debug]: Chunked body in response
[debug]: response 200 to GET https://crates.io/api/v1/crates/espup/versions
[debug]: dropping stream: Stream(RustlsStream)
[info]: Installing the Espressif Rust ecosystem
[debug]: Querying latest Xtensa Rust version from GitHub API
[debug]: Querying GitHub API: 'https://api.github.com/repos/esp-rs/rust-build/releases/latest'
[debug]: starting new connection: https://api.github.com/
[debug]: Parsing Xtensa Rust version: 1.85.0.0
[debug]: Querying GitHub API: 'https://api.github.com/repos/esp-rs/rust-build/releases?page=1&per_page=100'
[debug]: starting new connection: https://api.github.com/
[debug]: Latest Xtensa Rust version: 1.85.0.0
[debug]: Arguments:
            - Export file: "/Users/willsturgeon/export-esp.sh"
            - Host triple: x86_64-apple-darwin
            - LLVM Toolchain: Llvm { extended: false, file_name_libs: Some("libs-clang-esp-19.1.2_20250225-x86_64-apple-darwin.tar.xz"), file_name_full: None, host_triple: X86_64AppleDarwin, path: "/Users/willsturgeon/.rustup/toolchains/esp/xtensa-esp32-elf-clang/esp-19.1.2_20250225", repository_url: "https://github.com/espressif/llvm-project/releases/download/esp-19.1.2_20250225", version: "esp-19.1.2_20250225" }
            - Stable version: "stable"
            - Rust Toolchain: Some(XtensaRust { cargo_home: "/Users/willsturgeon/.cargo", dist_file: "rust-1.85.0.0-x86_64-apple-darwin.tar.xz", dist_url: "https://github.com/esp-rs/rust-build/releases/download/v1.85.0.0/rust-1.85.0.0-x86_64-apple-darwin.tar.xz", host_triple: "x86_64-apple-darwin", path: "/Users/willsturgeon/.rustup/toolchains/esp", rustup_home: "/Users/willsturgeon/.rustup", src_dist_file: "rust-src-1.85.0.0.tar.xz", src_dist_url: "https://github.com/esp-rs/rust-build/releases/download/v1.85.0.0/rust-src-1.85.0.0.tar.xz", toolchain_destination: "/Users/willsturgeon/.rustup/toolchains/esp", version: "1.85.0.0" })
            - Skip version parsing: false
            - Targets: {ESP32C2, ESP32P4, ESP32S3, ESP32H2, ESP32, ESP32C3, ESP32C6, ESP32S2}
            - Toolchain path: "/Users/willsturgeon/.rustup/toolchains/esp"
            - Toolchain version: None
[info]: Checking Rust installation
[info]: Installing RISC-V Rust targets ('riscv32imc-unknown-none-elf', 'riscv32imac-unknown-none-elf' and 'riscv32imafc-unknown-none-elf') for 'stable' toolchain
[warn]: Previous installation of LLVM exists in: '/Users/willsturgeon/.rustup/toolchains/esp/xtensa-esp32-elf-clang/esp-19.1.2_20250225'. Reusing this installation
[info]: Installing GCC (xtensa-esp-elf)
[debug]: GCC path: /Users/willsturgeon/.rustup/toolchains/esp/xtensa-esp-elf/esp-14.2.0_20240906
[warn]: Previous installation of GCC exists in: '/Users/willsturgeon/.rustup/toolchains/esp/xtensa-esp-elf/esp-14.2.0_20240906'. Reusing this installation
[info]: Creating symlink between '/Users/willsturgeon/.rustup/toolchains/esp/xtensa-esp32-elf-clang/esp-19.1.2_20250225/esp-clang/lib' and '/Users/willsturgeon/.espup/esp-clang'
[warn]: Installation for 'RISC-V Rust target' failed, retrying. Error: Failed to Install RISC-V targets for 'stable' toolchain
[info]: Uninstalling Xtensa Rust toolchain
[info]: Installing Xtensa Rust 1.85.0.0 toolchain
[debug]: starting new connection: https://github.com/
[info]: Installing RISC-V Rust targets ('riscv32imc-unknown-none-elf', 'riscv32imac-unknown-none-elf' and 'riscv32imafc-unknown-none-elf') for 'stable' toolchain
[warn]: Installation for 'RISC-V Rust target' failed, retrying. Error: Failed to Install RISC-V targets for 'stable' toolchain
[info]: Installing RISC-V Rust targets ('riscv32imc-unknown-none-elf', 'riscv32imac-unknown-none-elf' and 'riscv32imafc-unknown-none-elf') for 'stable' toolchain
[warn]: Installation for 'RISC-V Rust target' failed, retrying. Error: Failed to Install RISC-V targets for 'stable' toolchain
[info]: Installing RISC-V Rust targets ('riscv32imc-unknown-none-elf', 'riscv32imac-unknown-none-elf' and 'riscv32imafc-unknown-none-elf') for 'stable' toolchain
[warn]: Installation for 'RISC-V Rust target' failed, retrying. Error: Failed to Install RISC-V targets for 'stable' toolchain
Error: espup::toolchain::rust::install_riscv_target

  × Failed to Install RISC-V targets for 'stable' toolchain

So clearly something else is different between the version in cargo-binstall and yours. Maybe it's already been fixed. Let me investigate a bit more.

[wrsturgeon]

OK, so downloading upstream espup (main) and running with RUST_LOG=debug cargo run -- install works. I'm guessing that the cargo-binstall version is behind main, and something else fixed it. I'd be willing to close--if I install rustup, I bet the installation will go through.

[wrsturgeon]

Yes, installing with main works. I'm guessing this is a cargo-binstall problem.

[SergioGasquez]

I'm guessing that the cargo-binstall version is behind main

Yes, there have been some unreleased changes in main. Thanks for the details! Ill close the issue as is already solved and will be released at some point!