Handle .part extension when extracting downloads#561
Merged
SergioGasquez merged 1 commit intoesp-rs:mainfrom Apr 17, 2026
Merged
Handle .part extension when extracting downloads#561SergioGasquez merged 1 commit intoesp-rs:mainfrom
SergioGasquez merged 1 commit intoesp-rs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves the download extraction flow by correctly handling resumable downloads saved with a trailing .part extension, so archives like *.zip.part and *.tar.xz.part can be extracted successfully.
Changes:
- Update archive-extension detection to gracefully handle
.partfiles by inspecting the underlying stem extension. - Avoid panics when the archive path has no extension or has a non-UTF8 extension (now returns a controlled “unsupported extension” error).
- Document the fix in the changelog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/toolchain/mod.rs |
Detects real archive type when the downloaded file ends with .part, enabling extraction of resumed downloads. |
CHANGELOG.md |
Adds a “Fixed” entry describing the resumed-download extraction fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/esp-rs/xtensa-toolchain/actions/runs/24560529797/job/71807748098