[Draft] Integrate arduino-dsmr-2 changes #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… std::string * Remove GCC-specific extensions to make the code portable and compatible with the MSVC compiler. * Add unit tests * Move the license information from source files to a separate LICENSE file * Bug fix: use unsigned char in the tolower method * Remove reader.h: this file is dependent on Arduino and is not needed for the parser. * Remove examples * Remove the crc16.h file because only one function is needed from it. Place the needed function inside the parser.h * Make ParseResult movable
* Fix comment formatting: use "//" for all comments
…ine before the "(" symbol. matthijskooijman#22
* Add usage example. * Improve Readme.
0-0:96.13.0(303132333435 30313233343) * Workaround for matthijskooijman#50 Allow missing units if the value is 0: 0-1:24.2.1(632525252525S)(00000.000)
Add missing "kvar" units.
Fix use varh int units for kvarh float values.
Increase the version inside library.json.
* Rename dsmr namespace to arduino_dsmr_2
* EncryptedPacketAccumulator: add header consistency check
Add AveragedFixedField. It fixes the issue esphome/issues#4750
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes in arduino-dsmr that I have made for [DSMR] Remove dependency on Arduino framework. Various bug fixes. #11036.
Open issues:
esphome-libs/arduino-dsmrto only contain code used by esphome DSMR component? Or be generic?arduino-dmsr-2? The changes that I have made are not compatible with the classic Arduino boards. Thus, I think it might cause confusion if we continue using the originalarduino-dsmrname.Todo:
esphome-libsand what is the goals, for example it is only for esphome or generic.1.0.0. Do we even need PlatformIO package?