Revert "Bump sentencepiece from 0.2.0 to 0.2.1"#6346
Merged
Conversation
dosubot
bot
added
size:XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts the sentencepiece dependency to version 0.2.0. This is a simple but important change to address issues with a newer version. I've added one comment regarding documenting the reason for this version pin to improve future maintainability.
| "torch_optimizer", | ||
| "kaldiio>=2.18.0", | ||
| "sentencepiece==0.2.1", | ||
| "sentencepiece==0.2.0", |
Contributor
There was a problem hiding this comment.
To improve long-term maintainability, it's good practice to add a comment explaining why this dependency is pinned to a specific version. This context is valuable for future developers who might consider upgrading this package, as it will inform them about the potential issues with newer versions and the history behind this decision.
Suggested change
| "sentencepiece==0.2.0", | |
| "sentencepiece==0.2.0", # Pinned to 0.2.0 due to issues in v0.2.1 (reverts espnet/espnet#6345) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6345