Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Member
Author
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the project's dependencies, specifically bumping torch and torchaudio to version 2.5.1 and removing legacy audio backend configurations and unused imports. However, the tox.ini file includes several non-existent torchaudio versions (2.7.1, 2.8.0, and 2.9.1) which will cause environment setup failures.
| # content of: tox.ini , put in same dir as setup.py | ||
| [tox] | ||
| envlist = common_upstream-py310-audio2.1.2, | ||
| envlist = common_upstream-py311-audio2.9.1, |
Comment on lines
+16
to
+18
| audio2.7.1: {envpython} -m pip install torchaudio==2.7.1 | ||
| audio2.8.0: {envpython} -m pip install torchaudio==2.8.0 | ||
| audio2.9.1: {envpython} -m pip install torchaudio==2.9.1 |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the GitHub Actions CI workflows to support newer versions of
torchaudioand expands the workflow triggers to run on all branches, not justmain. The changes also update the Python version matrix and simplify the configuration.Workflow trigger updates:
.github/workflows/ci.ymland.github/workflows/espnet.ymlnow trigger on pushes to any branch, not justmain, in addition to pull requests. [1] [2]Dependency and matrix updates:
torchaudio-versionmatrix in both workflows is updated to test only recent versions:2.5.1,2.7.1,2.8.0, and2.9.1, removing older versions. [1] [2]torchaudioversion (2.9.1). [1] [2]includesection is simplified to only add the Python 3.12 andtorchaudio 2.9.1combination. [1] [2]