Skip to content

Update version#3

Merged
Fhrozen merged 5 commits into
mainfrom
pr-version
May 14, 2026
Merged

Update version#3
Fhrozen merged 5 commits into
mainfrom
pr-version

Conversation

@Fhrozen
Copy link
Copy Markdown
Member

@Fhrozen Fhrozen commented May 14, 2026

This pull request updates the version of the project to reflect a new release.

  • Versioning:
    • Updated the version number in s3prl/version.txt from 0.4.18 to 20260514, indicating a new release or build date.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 14, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version identifier in s3prl/version.txt from 0.4.18 to 20260514. Feedback was provided indicating that the new format violates PEP 440 and could cause issues with version comparison and dependency solvers. It is recommended to use a dotted calendar format, such as 2026.05.14, to ensure proper numerical comparison and compatibility.

Comment thread s3prl/version.txt Outdated
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels May 14, 2026
@Fhrozen Fhrozen merged commit 6553a49 into main May 14, 2026
12 of 13 checks passed
@Fhrozen Fhrozen deleted the pr-version branch May 14, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant