- 
                Notifications
    You must be signed in to change notification settings 
- Fork 7.7k
feat(ota): Add support for signed binaries #11968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
 👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
 Review and merge process you can expect ...
 | 
800dacd    to
    e8563d5      
    Compare
  
    5517c9b    to
    59e4a95      
    Compare
  
    | Test Results 76 files   76 suites   14m 43s ⏱️ Results for commit e2656bb. ♻️ This comment has been updated with latest results. | 
59e4a95    to
    66a7b7f      
    Compare
  
    66a7b7f    to
    31f717f      
    Compare
  
    | Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target. 
 Click to expand the detailed deltas report [usage change in BYTES]
 | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Nice new feature, but it adds 5k of flash usage! Users upgrading from actual core will loose this flash space without knowing why. Furthermore the signing can only be used when a key has been created. So imho it would be better to make this feature default off. Since generating the key needs to be done when wanting to use, setting the flag to activate is no problem. | 
| Must agree with the comment by @Jason2866 Increasing flash usage as new cores are introduced is a real issue. Certainly with OTA configurations. This is an advanced feature that should be "off" by default. | 
31f717f    to
    d599b41      
    Compare
  
    d599b41    to
    e2656bb      
    Compare
  
    
Description of Change
This pull request introduces secure OTA (Over-The-Air) firmware update capabilities with cryptographic signature verification to the ArduinoOTA library and its examples. The main focus is on enabling devices to only accept firmware that has been signed with an authorized private key, significantly improving security against unauthorized or tampered updates. The changes include new example code, documentation, build workflow updates, and modifications to the ArduinoOTA core to support signature verification.
Key changes:
Secure OTA Signature Verification Support
ArduinoOTAlibrary, allowing users to specify a signature verifier (RSA or ECDSA) via the newsetSignature()method. This ensures only signed firmware is accepted during OTA updates. [1] [2] [3] [4] [5] [6]New Example: SignedOTA
SignedOTAexample, including:SignedOTA.ino: Demonstrates secure OTA with signature verification, configurable for different algorithms and optional password protection.public_key.h: Contains a test RSA public key for demonstration purposes; users are instructed to generate and use their own keys.README.md: Comprehensive instructions for setup, key generation, signing firmware, and troubleshooting.ci.yml: Ensures the example is only built when WiFi support is present.Build and Workflow Enhancements
build_py_tools.yml) to include the newtools/bin_signing.pytool, which is required for signing firmware images as part of the secure OTA process. [1] [2]These changes collectively add a robust security layer to OTA updates, protecting devices from unauthorized or malicious firmware installations.
Test Scenarios
Tested locally
Related links
Closes #8141