Skip to content

fix(wifi): Fix WiFi.disconnect(true, true) not working #12004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

fix(wifi): Fix WiFi.disconnect(true, true) not working #12004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 14 additions & 19 deletions libraries/WiFi/src/STA.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,25 +525,6 @@ bool STAClass::connect(
#endif /* CONFIG_ESP_WIFI_ENTERPRISE_SUPPORT */

bool STAClass::disconnect(bool eraseap, unsigned long timeout) {
if (eraseap) {
if (!started()) {
log_e("STA not started! You must call begin first.");
return false;
}
wifi_config_t conf;
memset(&conf, 0, sizeof(wifi_config_t));
esp_err_t err = esp_wifi_set_config(WIFI_IF_STA, &conf);
if (err != ESP_OK) {
log_e("STA clear config failed! 0x%x: %s", err, esp_err_to_name(err));
return false;
}
}

if (!connected()) {
log_w("STA already disconnected.");
return true;
}

esp_err_t err = esp_wifi_disconnect();
if (err != ESP_OK) {
log_e("STA disconnect failed! 0x%x: %s", err, esp_err_to_name(err));
Expand All @@ -560,6 +541,20 @@ bool STAClass::disconnect(bool eraseap, unsigned long timeout) {
}
}

if (eraseap) {
if (!started()) {
log_e("STA not started! You must call begin first.");
return false;
}
wifi_config_t conf;
memset(&conf, 0, sizeof(wifi_config_t));
esp_err_t err = esp_wifi_set_config(WIFI_IF_STA, &conf);
if (err != ESP_OK) {
log_e("STA clear config failed! 0x%x: %s", err, esp_err_to_name(err));
return false;
}
}

return true;
}

Expand Down
Loading