Skip to content

Conversation

@Lee-Stone
Copy link
Contributor

Description of Change

Added battery management pins for the XIAO ESP32C5, defined as follows:

  • Battery voltage sampling pin (GPIO6)
  • Battery enable pin (GPIO26)

These definitions allow users to easily monitor the battery voltage on the XIAO ESP32C5 development board.

Test Scenarios

Tested and verified on the XIAO ESP32C5 hardware:

  • Reading battery voltage via GPIO6
  • Enabling/disabling battery function via GPIO26

Related links

espressif/arduino-esp32#11677

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Modify pin definition name":
    • summary looks empty
    • type/action looks empty
  • the commit message "feat(xiao esp32c5): Add definitions for the battery voltage sampling pin and the enable pin":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello Lee-Stone, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2125830

@P-R-O-C-H-Y P-R-O-C-H-Y added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Dec 1, 2025
@P-R-O-C-H-Y
Copy link
Member

@Lee-Stone PLease check my comment and sing the CLA. Also can you post any docs leading to the XIAO C5?

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending CLA ⚠️ Contributor is required to sign the CLA label Dec 1, 2025
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
@Lee-Stone
Copy link
Contributor Author

@Lee-Stone PLease check my comment and sing the CLA. Also can you post any docs leading to the XIAO C5?

OK, modified. And I'm sorry, I can't provide the documentation for xiao esp32c5 at the moment, but it will be available on seeed soon, and a related wiki will be provided then.

@P-R-O-C-H-Y
Copy link
Member

@Lee-Stone Have you signed the CLA?

@Lee-Stone
Copy link
Contributor Author

@Lee-Stone Have you signed the CLA?

Sorry, it's signed now.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Pending CLA ⚠️ Contributor is required to sign the CLA labels Dec 1, 2025
@me-no-dev me-no-dev merged commit a850760 into espressif:master Dec 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants