-
Notifications
You must be signed in to change notification settings - Fork 7.8k
fix(ble): Fix Advertising data being overwritten #12096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 18m 34s ⏱️ Results for commit 711ccfa. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Description of Change
This pull request enhances memory management and object copying for the
BLEAdvertisedDeviceclass, ensuring safe handling of the advertising payload buffer. The changes add a destructor, copy constructor, and assignment operator, and improve how the payload buffer is allocated, copied, and freed to avoid memory leaks and ensure correct behavior when objects are copied or reassigned.Memory management and object lifecycle improvements:
BLEAdvertisedDeviceto properly manage the dynamicm_payloadbuffer, ensuring deep copies and freeing memory when needed. (libraries/BLE/src/BLEAdvertisedDevice.cpp,libraries/BLE/src/BLEAdvertisedDevice.h) [1] [2]m_payloadandm_payloadLengthto safe default values. (libraries/BLE/src/BLEAdvertisedDevice.cpp)Payload buffer handling improvements:
parseAdvertisementto always make a copy of the payload buffer and to append scan response data safely, preventing use-after-free or double-free issues. (libraries/BLE/src/BLEAdvertisedDevice.cpp)setPayloadto allocate, copy, and append payload data safely, with error checking and freeing of previous buffers as needed. (libraries/BLE/src/BLEAdvertisedDevice.cpp)Test Scenarios
Tested locally
Related links
Closes #12075