Skip to content

Conversation

@JakubAndrysek
Copy link
Collaborator

This pull request adds new hardware validation diagrams and a basic test for SD card SPI connectivity across various ESP32 board variants. The main focus is to ensure compatibility and proper wiring for SD card modules on different ESP32 development boards.

Hardware validation diagrams:

  • Added diagram.esp32.json for ESP32 DevKitC V4, showing connections for two microSD cards.
  • Added diagram.esp32c3.json for ESP32-C3 DevKitM-1, illustrating wiring for one microSD card.
  • Added diagram.esp32c6.json for ESP32-C6 DevKitC-1, including connections for two microSD cards.
  • Added diagram.esp32s2.json for ESP32-S2 DevKitM-1, detailing wiring for two microSD cards.
  • Added diagram.esp32s3.json for ESP32-S3 DevKitC-1, showing two microSD cards connected.

Testing:

  • Added a simple SPI test function test_spi in test_sdcard.py to check SD card communication, using Unity test output with a specified timeout.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Apply suggestions from code review":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello JakubAndrysek, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against fcae8c8

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Test Results

 90 files   90 suites   27m 51s ⏱️
 56 tests  55 ✅ 0 💤 0 ❌ 1 🔥
605 runs  598 ✅ 0 💤 0 ❌ 7 🔥

For more details on these errors, see this check.

Results for commit fcae8c8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive SD card validation infrastructure for multiple ESP32 board variants, including hardware wiring diagrams and extensive functional tests for SD card SPI connectivity.

Key Changes:

  • Adds hardware validation diagrams for 5 ESP32 variants (ESP32, ESP32-C3, ESP32-C6, ESP32-S2, ESP32-S3) with microSD card wiring specifications
  • Implements 10 comprehensive test cases covering basic operations, file I/O, directory management, and limits testing
  • Creates a flexible test framework supporting multiple SPI configurations per board

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tests/validation/sdcard/test_sdcard.py Python test wrapper that invokes Unity test framework with 280-second timeout
tests/validation/sdcard/sdcard.ino Main Arduino test suite with SPITestConfig class and 10 comprehensive SD card test functions
tests/validation/sdcard/diagram.esp32.json Wokwi hardware diagram for ESP32 DevKit C V4 with two microSD cards on separate SPI buses
tests/validation/sdcard/diagram.esp32s3.json Wokwi hardware diagram for ESP32-S3 DevKitC-1 with two microSD cards
tests/validation/sdcard/diagram.esp32s2.json Wokwi hardware diagram for ESP32-S2 DevKitM-1 with two microSD cards (contains wiring error)
tests/validation/sdcard/diagram.esp32c6.json Wokwi hardware diagram for ESP32-C6 DevKitC-1 with two microSD cards sharing SPI bus
tests/validation/sdcard/diagram.esp32c3.json Wokwi hardware diagram for ESP32-C3 DevKitM-1 with single microSD card

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@P-R-O-C-H-Y P-R-O-C-H-Y added Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure. Status: Review needed Issue or PR is awaiting review labels Dec 10, 2025
@lucasssvaz lucasssvaz added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Dec 10, 2025
@me-no-dev me-no-dev merged commit 780505f into espressif:master Dec 10, 2025
37 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing Related to continuous integration, automated testing, or test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants