Skip to content

tell IDF build system to use Clang toolchain (IDFGH-14189) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

tell IDF build system to use Clang toolchain (IDFGH-14189) #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pyclang/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,14 +205,26 @@ def idf_reconfigure(self, *args) -> 'Runner':
folder = args[0]
log_fs = args[1]

# tell IDF build system to prepare compilation commands for Clang based toolchain
env = os.environ.copy()
env['IDF_TOOLCHAIN'] = 'clang'

run_cmd(
f'idf.py -B {self.build_dir} reconfigure', log_stream=log_fs, cwd=folder
f'idf.py -B {self.build_dir} reconfigure', log_stream=log_fs, cwd=folder, env=env
)

@chain
def remove_command_flags(self, *args):
folder = args[0]

# see if the IDF version recognizes Clang toolchain
with open(os.path.join(folder, self.build_dir, 'CMakeCache.txt'), 'r') as cmake_cache_fp:
cmake_cache = cmake_cache_fp.read()
if 'IDF_TOOLCHAIN:STRING=clang' in cmake_cache:
# it does! nothing to do here, compile_commands.json already contains clang-compatible flags
return

# if it doesn't, need to remove GCC-specific flags from compile_commands.json
compiled_command_fp = os.path.join(
folder, self.build_dir, self.COMPILE_COMMANDS_FILENAME
)
Expand Down