Skip to content

Conversation

@mrjohannchang
Copy link
Contributor

@mrjohannchang mrjohannchang commented Aug 8, 2025

Description

This original implementation handles registered multi-click callbacks within an unnecessary additional loop. This patch simplifies it.

Related

Testing

This patch does not introduce any new function, so no new test cases should be added.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello mrjohannchang, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 80af98a

@github-actions github-actions bot changed the title refactor: simplify the callback handling of multi-click refactor: simplify the callback handling of multi-click (AEGHB-1174) Aug 8, 2025
@leeebo leeebo added the button label Aug 11, 2025
@lijunru-hub
Copy link
Contributor

LGTM!

Copy link
Collaborator

@leeebo leeebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha=80af98a157de1a0600106ae6af1ba9d26ff7010e

@leeebo leeebo self-requested a review August 12, 2025 09:01
@leeebo
Copy link
Collaborator

leeebo commented Aug 12, 2025

sha=80af98a157de1a0600106ae6af1ba9d26ff7010e

@zhanzhaocheng zhanzhaocheng merged commit 19e72db into espressif:master Aug 15, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants