Skip to content

Conversation

@gabsuren
Copy link
Collaborator

@gabsuren gabsuren commented Nov 3, 2025

Note

Stops resetting client->ping_tick_ms on read poll timeout so periodic PINGs proceed on schedule during active traffic.

  • WebSocket client (components/esp_websocket_client/esp_websocket_client.c):
    • Adjust PING scheduling in WEBSOCKET_STATE_CONNECTED by removing client->ping_tick_ms = _tick_get_ms() after read poll timeout, preventing unintended PING delays.

Written by Cursor Bugbot for commit 7f42432. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gabsuren gabsuren self-assigned this Nov 3, 2025
@gabsuren gabsuren requested a review from david-cermak November 3, 2025 10:55
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@gabsuren gabsuren merged commit 318bca1 into espressif:master Nov 5, 2025
102 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants