fix(usb_host_test): Fix target tests build for esp32s31#482
Merged
Conversation
190e74b to
6c3cc39
Compare
igi540
approved these changes
Apr 22, 2026
tore-espressif
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
USB Host target test: enum
Fixing build of usb host enum test for esp32s31. Failing in CI with following log:
CI error log
USB Host target test: HCD
Fixing build of usb host HCD test for esp32s31. Failing in CI with following log:
CI error log
Related
Checklist
Before submitting a Pull Request, please ensure the following:
Note
Low Risk
Low risk: changes are limited to CI test enablement rules and a test-only include cleanup, with no impact on production USB stack behavior.
Overview
Resolves esp32s31 target-test build failures by disabling the USB host enumeration target test on
esp32s31via.build-test-rules.yml(it relies on FSLS PHY attach/detach emulation signals not present on that target).Also fixes the USB host HCD target test build by removing the
soc/usb_wrap_struct.hinclude fromhost/usb/test/target_test/common/hcd_common.c, avoiding a missing-header error on esp32s31.Reviewed by Cursor Bugbot for commit fe0d9d3. Bugbot is set up for automated code reviews on this repo. Configure here.