Skip to content

ci: Update workflows for Jira sync and DangerJS#12

Merged
peterdragun merged 1 commit intomasterfrom
ci/update_workflows
Mar 31, 2026
Merged

ci: Update workflows for Jira sync and DangerJS#12
peterdragun merged 1 commit intomasterfrom
ci/update_workflows

Conversation

@peterdragun
Copy link
Copy Markdown
Collaborator

@peterdragun peterdragun commented Mar 30, 2026

This PR includes:

  • Removing unnecessary checkout and instructions from DangerJS
  • Removing checkout and merging Jira workflows
  • Removed workflows from yamlfix to avoid strange formatting and inconsistencies with other repositories

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello peterdragun, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against dc414b1

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines GitHub CI automation around Jira synchronization and DangerJS by consolidating multiple Jira-sync workflows into a single workflow and simplifying the DangerJS workflow configuration. It also aligns YAML formatting rules with the project’s Python line length to avoid undesirable reformatting.

Changes:

  • Add yamlfix line_length = 120 to prevent awkward YAML reflow.
  • Replace multiple Jira sync workflows with a single consolidated sync-jira.yml (and remove unnecessary checkouts).
  • Simplify DangerJS workflow by removing checkout and custom instruction inputs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Configures yamlfix line length to 120 for consistent formatting.
.github/workflows/sync-jira.yml New consolidated Jira sync workflow replacing prior separate workflows.
.github/workflows/new_prs.yml Removed (functionality folded into sync-jira.yml).
.github/workflows/new_issues.yml Removed (functionality folded into sync-jira.yml).
.github/workflows/issue_comment.yml Removed (functionality folded into sync-jira.yml).
.github/workflows/dangerjs.yml Removes unnecessary checkout and instruction-related inputs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@peterdragun peterdragun force-pushed the ci/update_workflows branch 2 times, most recently from 87d7796 to f5a7f92 Compare March 31, 2026 08:17
@peterdragun peterdragun force-pushed the ci/update_workflows branch from f5a7f92 to dc414b1 Compare March 31, 2026 08:21
@peterdragun peterdragun requested a review from Dzarda7 March 31, 2026 08:26
@Dzarda7
Copy link
Copy Markdown

Dzarda7 commented Mar 31, 2026

I am curious why you do not want to format workflow yaml, but no problem with that, LGTM, thanks.

@peterdragun
Copy link
Copy Markdown
Collaborator Author

peterdragun commented Mar 31, 2026

Because with linting, the code will look like this 😅 and I hate that TBH:
image
When I make the line longer, it affects action.yaml as well, and that would bring a lot of unrelated changes to this MR because yamlfix will force the lines to be as long as is allowed before a line break.

Another reason is similarity with other projects - I can tell now from the first look if this is mostly the same as in other repositories, based on the quick look. If there were a different styling, I would have to double-check.

@Dzarda7
Copy link
Copy Markdown

Dzarda7 commented Mar 31, 2026

Thanks, no problem, expected something like that.

@peterdragun peterdragun merged commit c6ab6ff into master Mar 31, 2026
2 checks passed
@peterdragun peterdragun deleted the ci/update_workflows branch March 31, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants