OLD: pdfrx 3.0 #506
Replies: 2 comments
|
Agreed the PRs are changing a lot of things, but actually mostly internally rather than user facing - custom layouts continue to work with a minor signature change for the callback, and discrete mode is a new optional feature. But of course you need to consider these changes carefully, so that's why I put them in draft PRs, and also broke them into 2. Looking at the highly requested features, it certainly seems that Snap pages? #112 has quite a few upvotes , and this is directly addressed in #505 if I understand the request. I think it also provides the basis for #104 (single page view) - #505 already doesn't render neighboring pages when pinch zooming out, and this could be extended to the general case so that only the current page is rendered unless the user is panning at a boundary. I also notice the issue with current page detection (#347), and #504 includes an alternative visiblePageRange which makes more sense with spread layouts like facing pages, or when the user is zoomed out and many pages are displaying. At least one popular commercial PDF reader uses page ranges as the only current page display. I think this works in conjunction with detecting the best candidate current page, and I'm happy to have a look at ways we might improve that. The other issues seem more like edge cases, but I can see that #111 (How to place PDF on top-side of view (not to center) is something that could readily address as part of enhanced layout changes, and I'm happy to look at this one. The other issues I see we should consider addressing in enhanced layout is #249 (page rotation), and readily enabling horizontal facing pages (#103). Do you propose creating a 3.0.0 branch?
|
|
The situation is a little changed; so continue the discussion on #534. |
Uh oh!
There was an error while loading. Please reload this page.
@enhancient
Regarding PR #504, #505, I really appreciate your contribution.
But the PRs are changing the things a lot and it results in brand new version; 3.0 or such.
So, before doing such jobs, we should summarize outstanding issues, which should be implemented on pdfrx 3.0.
On the issues, we have several highly requested features and also things to be fixed:
All reactions