Skip to content

Conversation

@thyttan
Copy link
Collaborator

@thyttan thyttan commented Oct 7, 2024

This PR seems to fix the following. Tested in the Bangle.js 1 emulator on the Web IDE.

Just tried on emulated Bangle.js 1 and got:

Uncaught Error: Can't read property 'scroll' of undefined
 at line 20 col 1070 in alarm.app.js
...mMenu,10,e,index,undefined,scroller.scroll,group)
                                      ^
in function "onchange" called from line 3 col 106
...onchange)a.onchange(a.value);Bangle.touchHandler==u&&d.draw(...
                              ^
in function "select" called from line 1 col 22
a?d.move(a):d.select()
                     ^
in function "d" called from line 1 col 3
d()
  ^
in function called from system
> 

Looking at the git blame it seems to have been around since 2023-11-14.

Originally posted by @thyttan in #3604 (comment)

@thyttan thyttan requested a review from gfwilliams October 7, 2024 18:53
@gfwilliams
Copy link
Member

Thanks! Good spot - yes, we don't use a scroller on Bangle.js1 because we can't scroll just part of the screen

@gfwilliams gfwilliams merged commit 2e47a13 into espruino:master Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants