Skip to content

Fix custom scrollers so they forward type of touch #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Fix custom scrollers so they forward type of touch #3609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4771e0f
swscroll: forward the type of touch (short/long).
Oct 11, 2024
c614891
kineticscroll: forward the type of touch (short/long).
Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/kineticscroll/ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
0.02: Minor code improvements
0.03: Better scrolling behaviour
0.04: Fix incorrect appRect handling (missing back buttons and doubled menu titles)
0.05: Bring in change from the firmware implementation forwarding the type of touch (short/long).
2 changes: 1 addition & 1 deletion apps/kineticscroll/boot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
if ((menuScrollMin<0 || i>=0) && i<options.c){
let yAbs = (e.y + rScroll - R.y);
let yInElement = yAbs - i*options.h;
options.select(i, {x:e.x, y:yInElement});
options.select(i, {x:e.x, y:yInElement, type:e.type});
}
};

Expand Down
6 changes: 3 additions & 3 deletions apps/kineticscroll/boot.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions apps/kineticscroll/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{ "id": "kineticscroll",
"name": "Kinetic Scroll",
"shortName":"Kinetic Scroll",
"version": "0.04",
"version": "0.05",
"description": "Replacement for the system scroller with kinetic scrolling.",
"icon": "app.png",
"type": "bootloader",
"tags": "system",
"supports" : ["BANGLEJS2"],
"supports" : ["BANGLEJS2"],
"readme": "README.md",
"storage": [
{"name":"kineticscroll.boot.js","url":"boot.min.js"}
Expand Down
2 changes: 1 addition & 1 deletion apps/lint_exemptions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,7 @@ module.exports = {
]
},
"apps/kineticscroll/boot.min.js": {
"hash": "1345b3c556f1a268a81c3a57825d096d9bbce9740217339aa6d79223d9daad4d",
"hash": "0814125a19aff5c608b9357926cd4a4c038334e31b0d07a70deefaf2c77959b9",
"rules": [
"no-cond-assign"
]
Expand Down
1 change: 1 addition & 0 deletions apps/swscroll/ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
0.05: Fix for the rebase in ver 0.04. Check boxes didn't behave but now they do.
0.06: Minor code improvements
0.07: Minor code improvements
0.08: Bring in change from the firmware implementation forwarding the type of touch (short/long).
2 changes: 1 addition & 1 deletion apps/swscroll/boot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Bangle.setUI({
if ((menuScrollMin<0 || i>=0) && i<options.c){
let yAbs = (e.y + rScroll - R.y);
let yInElement = yAbs - i*options.h;
options.select(i, {x:e.x, y:yInElement});
options.select(i, {x:e.x, y:yInElement, type:e.type});
}
}
});
Expand Down
2 changes: 1 addition & 1 deletion apps/swscroll/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "swscroll",
"name": "Swipe menus",
"version": "0.07",
"version": "0.08",
"description": "Replace built in E.showScroller to act on swipe instead of drag. Navigate menus in discrete steps instead of a continuous motion.",
"readme": "README.md",
"icon": "app.png",
Expand Down
Loading