Skip to content

Conversation

@spycat111
Copy link
Contributor

This single PR addresses two separate issues:

Bugfix: Non-ASCII punctuation in crsclock.js
Installing via the Development App Loader produced parsing errors and garbled text, whereas uploading via Web IDE did not. After investigation, non-ASCII dashes in the source were being mangled by the Espruino minifier/firmware, causing:

Syntax error:

Uncaught SyntaxError: Got UNFINISHED REGEX expected ']'
(due to U+2212 MINUS SIGN in BT calibration menu, ≈ lines 612–614)

Mojibake:
EN DASH (U+2013) in the sleep-window and range prompts rendered as â on device (lines 84–86, 714 & 723)

Fix: Normalise all EN DASH and MINUS SIGN characters to the ASCII hyphen-minus (-).

Documentation: Patent & Licensing clarity in README.md
To reinforce transparency around our UK-patented method while preserving open-source accessibility, we’ve updated the Patent and Licensing section to:

Note that the patent does not require licensing for non-commercial, research, educational, or personal use within the open-source community.

Advise that commercial or broad distribution may require permission or licensing, and direct inquiries to the author.

Preserve the existing MIT-license wording intact.

Changes:

crsclock.js

Replaced all U+2013 (EN DASH) and U+2212 (MINUS SIGN) with - in menu labels and prompt strings.

crsclock.app.js (auto-generated)

Will now minify without regex errors.

README.md

Under Patent and Licensing, added a prominent “Note” about non-commercial use.

Clarified permitted use cases vs. those requiring further licensing.

Retained existing MIT license text unmodified.

@bobrippling
Copy link
Collaborator

LGTM, tagging @gfwilliams for the license stuff

@spycat111
Copy link
Contributor Author

spycat111 commented Jun 15, 2025

This PR relate to #3883 and #3881.

@gfwilliams
Copy link
Member

Thanks! I'll merge this for now as it's not hit the main app loader yet, but generally we should bump the version number.

I'll reply on the license thing in #3878

@gfwilliams gfwilliams merged commit 12f7edd into espruino:master Jun 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants