Skip to content

Conversation

@bobrippling
Copy link
Collaborator

@bobrippling bobrippling commented Oct 30, 2025

We now:

  • No longer limit map drawing to tracks whose initial data contained a latitude (if (trackData.Latitude) { ... })
  • Return after resolveing errors with track infos (this should be reject but I don't want to regress the slightly intertwined promise-heavy code)
  • Have a slightly faster longitude/latitude lookup for previews
  • Note BangleJS as the GPX author

I've also added a note about how we would specify the track type (run, ride, swim, etc) but not implemented this

@bobrippling bobrippling changed the title recorder: load full map, add author info and activity type recorder: load full map and add author info Oct 31, 2025
@bobrippling bobrippling marked this pull request as ready for review October 31, 2025 12:21
@bobrippling
Copy link
Collaborator Author

@gfwilliams are you happy with GPX tracks exported from bangles being tagged as coming from here?

<metadata>
<author>
<name>BangleJS</name>
<link href="https://banglejs.com/" />
</author>
</metadata>

@gfwilliams
Copy link
Member

I think that's fine - it should probably say Bangle.js instead though.

The link could actually reference https://banglejs.com/apps/?id=recorder - it might be helpful to differentiate that as the actual source?

@bobrippling
Copy link
Collaborator Author

Sounds good - updated. Will give it a little test

@bobrippling
Copy link
Collaborator Author

Working fine, will merge shortly

@bobrippling bobrippling merged commit 26b4fe1 into espruino:master Nov 13, 2025
1 check passed
@bobrippling bobrippling deleted the recorder/reload-map branch November 13, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants