This should not be used everywhere. The rust compiler knows a lot better then we do when to use it.
https://matklad.github.io/2021/07/09/inline-in-rust.html#Inlining-in-Practice
This is also forcing a lot of manual impls that are not worth it.
This would only be worth it if we can definitely show in multiple workloads that it's creating significantly more cycles for the zk proof. Then care would need to be taken to actually get the manual impls correct.
@pixelcircuits is there any other reason this was done?
This should not be used everywhere. The rust compiler knows a lot better then we do when to use it.
https://matklad.github.io/2021/07/09/inline-in-rust.html#Inlining-in-Practice
This is also forcing a lot of manual impls that are not worth it.
This would only be worth it if we can definitely show in multiple workloads that it's creating significantly more cycles for the zk proof. Then care would need to be taken to actually get the manual impls correct.
@pixelcircuits is there any other reason this was done?