Skip to content

feat: create workflow to lighthouse#22

Merged
jonataspinto merged 11 commits intodevelopfrom
feat/lighthouse-check-workflow
Feb 14, 2022
Merged

feat: create workflow to lighthouse#22
jonataspinto merged 11 commits intodevelopfrom
feat/lighthouse-check-workflow

Conversation

@jonataspinto
Copy link
Copy Markdown
Member

@jonataspinto jonataspinto commented Feb 9, 2022

Description

Validação com dados do Lighthouse no workflow para build/deploy na AWS.

Developer Checks

  • PR title & commits adhere to Conventional Commit Specification
  • PR is targeting correct branch, is up-to-date, & no merge conflicts
  • Tested on browser device
  • Tested on Mobile device

Copy link
Copy Markdown
Member Author

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

Copy link
Copy Markdown
Member Author

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

@estartandodevs
Copy link
Copy Markdown

@jonataspinto
Copy link
Copy Markdown
Member Author

Aí galera! Muito top!

@alanaraujop @yagovaluchedevs @ramonxm @Brenont @joaoprferreira

@ramonxm
Copy link
Copy Markdown
Member

ramonxm commented Feb 9, 2022

Aí galera! Muito top!

@alanaraujop @yagovaluchedevs @ramonxm @Brenont @joaoprferreira

Ficou top 🎯 já até reclamou que não ta na melhores práticas rsrs

@ramonxm
Copy link
Copy Markdown
Member

ramonxm commented Feb 14, 2022

Fala @jonataspinto, vai subir mais algo nessa branch ou podemos mergear? Vai falhar o deploy mas acho que não tem muito o que fazer, vamos corrigindo no desenvolvimento.

@jonataspinto
Copy link
Copy Markdown
Member Author

Fala @jonataspinto, vai subir mais algo nessa branch ou podemos mergear? Vai falhar o deploy mas acho que não tem muito o que fazer, vamos corrigindo no desenvolvimento.

Mergeando...

@jonataspinto jonataspinto merged commit e570715 into develop Feb 14, 2022
@jonataspinto jonataspinto deleted the feat/lighthouse-check-workflow branch February 14, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants