Skip to content

[FEATURE] Header#43

Merged
ramonxm merged 9 commits intodevelopfrom
feature/header
Feb 26, 2022
Merged

[FEATURE] Header#43
ramonxm merged 9 commits intodevelopfrom
feature/header

Conversation

@ramonxm
Copy link
Copy Markdown
Member

@ramonxm ramonxm commented Feb 25, 2022

Ticket

Description

Criação da Header da aplicação
\

Screenshots / Videos

image

Developer Checks

  • PR title & commits adhere to Conventional Commit Specification
  • PR is targeting correct branch, is up-to-date, & no merge conflicts
  • Tested on browser device
  • Tested on Mobile device

@ramonxm ramonxm self-assigned this Feb 25, 2022
@jonataspinto
Copy link
Copy Markdown
Member

PQP 31 files

@jonataspinto
Copy link
Copy Markdown
Member

depois do carnaval eu termino 😆

@jonataspinto
Copy link
Copy Markdown
Member

Lighthouse result for https://www.estartandodevs.com.br/
Metric Score
Performance 0.55
First Contentful Paint 3.7 s
Time to Interactive 6.5 s
Speed Index 4.8 s
Total Blocking Time 620 ms
Largest Contentful Paint 4.3 s
Cumulative Layout Shift 0
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
Metric Score
Performance 0.97
First Contentful Paint 1.4 s
Time to Interactive 4.8 s
Speed Index 2.3 s
Total Blocking Time 120 ms
Largest Contentful Paint 1.4 s
Cumulative Layout Shift 0.004

Copy link
Copy Markdown
Member

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

Comment thread src/components/Header/styles.ts Outdated
Comment thread src/components/Header/styles.ts Outdated
Comment thread src/components/LinkWrapper/styles.ts
@jonataspinto
Copy link
Copy Markdown
Member

Lighthouse result for https://www.estartandodevs.com.br/
Metric Score
Performance 0.62
First Contentful Paint 3.1 s
Time to Interactive 4.8 s
Speed Index 4.7 s
Total Blocking Time 470 ms
Largest Contentful Paint 4.9 s
Cumulative Layout Shift 0
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
Metric Score
Performance 0.94
First Contentful Paint 1.7 s
Time to Interactive 5.2 s
Speed Index 2.7 s
Total Blocking Time 80 ms
Largest Contentful Paint 2.2 s
Cumulative Layout Shift 0.011

Copy link
Copy Markdown
Member

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

Copy link
Copy Markdown
Member

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonataspinto
Copy link
Copy Markdown
Member

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

@ramonxm pwa subiu um cadinho 🤔

@jonataspinto
Copy link
Copy Markdown
Member

jonataspinto commented Feb 26, 2022

Merrrgeeeeeee

@ramonxm ramonxm merged commit ce93ae9 into develop Feb 26, 2022
@ramonxm ramonxm deleted the feature/header branch February 26, 2022 00:46
@ramonxm
Copy link
Copy Markdown
Member Author

ramonxm commented Feb 26, 2022

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

@ramonxm pwa subiu um cadinho 🤔

Acha válido ativar? Sei configurar o nextpwa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants