Skip to content

Feature/course#44

Merged
yagovaluchedevs merged 4 commits intodevelopfrom
feature/course
Feb 26, 2022
Merged

Feature/course#44
yagovaluchedevs merged 4 commits intodevelopfrom
feature/course

Conversation

@yagovaluchedevs
Copy link
Copy Markdown
Contributor

@yagovaluchedevs yagovaluchedevs commented Feb 26, 2022

Ticket | Mocks

Description

Implementando o componente referente aos cursos que teremos no projeto.

Dev Notes

  • If any developer notes are required, list them here. If not, remove the 'Notes' section.

Testing

Steps

  1. List all steps in a numbered list

Screenshots / Videos

Captura de Tela 2022-02-26 às 17 40 03

Developer Checks

  • PR title & commits adhere to Conventional Commit Specification
  • PR is targeting correct branch, is up-to-date, & no merge conflicts
  • Tested on browser device
  • Tested on Mobile device

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 26, 2022

✔️ Deploy Preview for dev-estartandodevs ready!

🔨 Explore the source changes: af114de

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-estartandodevs/deploys/621a98cfc914b70007df5bc5

😎 Browse the preview: https://deploy-preview-44--dev-estartandodevs.netlify.app/

@jonataspinto
Copy link
Copy Markdown
Member

Lighthouse result for https://www.estartandodevs.com.br/
Metric Score
Performance 0.5
First Contentful Paint 3.8 s
Time to Interactive 6.6 s
Speed Index 5.1 s
Total Blocking Time 800 ms
Largest Contentful Paint 4.2 s
Cumulative Layout Shift 0
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
Metric Score
Performance 0.96
First Contentful Paint 1.5 s
Time to Interactive 5.0 s
Speed Index 2.2 s
Total Blocking Time 150 ms
Largest Contentful Paint 1.5 s
Cumulative Layout Shift 0.001

Copy link
Copy Markdown
Member

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

Comment thread src/components/Courses/index.tsx Outdated
Comment thread src/components/Courses/styles.ts Outdated
Comment thread src/components/Courses/styles.ts Outdated
Comment thread src/components/Courses/styles.ts Outdated
Comment thread src/pages/index.tsx
Comment thread src/styles/global.tsx
@jonataspinto
Copy link
Copy Markdown
Member

Lighthouse result for https://www.estartandodevs.com.br/
Metric Score
Performance 0.55
First Contentful Paint 3.4 s
Time to Interactive 6.3 s
Speed Index 4.1 s
Total Blocking Time 500 ms
Largest Contentful Paint 6.1 s
Cumulative Layout Shift 0
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
Metric Score
Performance 0.96
First Contentful Paint 1.6 s
Time to Interactive 4.9 s
Speed Index 2.5 s
Total Blocking Time 100 ms
Largest Contentful Paint 1.6 s
Cumulative Layout Shift 0.044

Copy link
Copy Markdown
Member

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

@yagovaluchedevs yagovaluchedevs merged commit feec52d into develop Feb 26, 2022
@yagovaluchedevs yagovaluchedevs deleted the feature/course branch February 26, 2022 21:20
<S.ListModulesContainer>
{exhibition &&
literalObjectCall.courseModules.map((item, index) => (
<p key={index}>- {item}</p>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Não entendi pq o lint não reclamou. Pode ajeitar @yagovaluchedevs ?

};

const Courses = ({ course }: PropsCourse) => {
const [exhibition, setExhibition] = useState(false);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poderíamos usar query params mais pra frente, assim quando compartilhar, já vai com o box aberto.

Comment thread public/eye.svg
@@ -0,0 +1,29 @@
<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esqueci de por esse no clodnary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants