Skip to content

[Feature]: implementing server side rendering with data of the cloud-function#56

Merged
jonataspinto merged 7 commits intodevelopfrom
feature/integration-with-lambda
Mar 2, 2022
Merged

[Feature]: implementing server side rendering with data of the cloud-function#56
jonataspinto merged 7 commits intodevelopfrom
feature/integration-with-lambda

Conversation

@jonataspinto
Copy link
Copy Markdown
Member

Screenshots / Videos

image

Developer Checks

  • PR title & commits adhere to Conventional Commit Specification
  • PR is targeting correct branch, is up-to-date, & no merge conflicts
  • Tested on browser device
  • Tested on Mobile device

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 2, 2022

✔️ Deploy Preview for dev-estartandodevs ready!

🔨 Explore the source changes: ce79a60

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-estartandodevs/deploys/621fe8cc9c2e6a0007afad36

😎 Browse the preview: https://deploy-preview-56--dev-estartandodevs.netlify.app/

@jonataspinto jonataspinto self-assigned this Mar 2, 2022
@ramonxm
Copy link
Copy Markdown
Member

ramonxm commented Mar 2, 2022

Lgtm

Comment thread src/pages/perguntas-frequentes.tsx Outdated
Comment thread src/services/getSiteData.ts
Comment thread src/services/getSiteData.ts Outdated
@jonataspinto jonataspinto force-pushed the feature/integration-with-lambda branch from 819e0ad to 05bac34 Compare March 2, 2022 21:07
@jonataspinto
Copy link
Copy Markdown
Member Author

Lighthouse result for https://www.estartandodevs.com.br/
Metric Score
Performance 0.45
First Contentful Paint 4.1 s
Time to Interactive 6.9 s
Speed Index 5.4 s
Total Blocking Time 600 ms
Largest Contentful Paint 5.8 s
Cumulative Layout Shift 0
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
Metric Score
Performance 0.94
First Contentful Paint 1.8 s
Time to Interactive 5.5 s
Speed Index 2.3 s
Total Blocking Time 170 ms
Largest Contentful Paint 2.1 s
Cumulative Layout Shift 0.044

Copy link
Copy Markdown
Member Author

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

Copy link
Copy Markdown
Member Author

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

@jonataspinto
Copy link
Copy Markdown
Member Author

Lighthouse result for https://www.estartandodevs.com.br/
Metric Score
Performance 0.58
First Contentful Paint 3.8 s
Time to Interactive 6.9 s
Speed Index 4.8 s
Total Blocking Time 510 ms
Largest Contentful Paint 4.3 s
Cumulative Layout Shift 0
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
Metric Score
Performance 0.95
First Contentful Paint 1.6 s
Time to Interactive 5.3 s
Speed Index 2.5 s
Total Blocking Time 130 ms
Largest Contentful Paint 1.9 s
Cumulative Layout Shift 0.042

@jonataspinto jonataspinto merged commit e0e6b01 into develop Mar 2, 2022
@jonataspinto jonataspinto deleted the feature/integration-with-lambda branch March 2, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants