Feature/student profile#58
Merged
jonataspinto merged 19 commits intodevelopfrom Mar 3, 2022
Merged
Conversation
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
…e/student-profile Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
|
✔️ Deploy Preview for dev-estartandodevs ready! 🔨 Explore the source changes: 8c68595 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-estartandodevs/deploys/6220db174230b8000770e11f 😎 Browse the preview: https://deploy-preview-58--dev-estartandodevs.netlify.app/ |
ramonxm
requested changes
Mar 2, 2022
jonataspinto
requested changes
Mar 2, 2022
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Signed-off-by: João Pedro <joaof082@gmail.com>
Member
Lighthouse result for https://www.estartandodevs.com.br/
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
|
jonataspinto
reviewed
Mar 3, 2022
Member
jonataspinto
left a comment
jonataspinto
left a comment
There was a problem hiding this comment.
| Device | URL |
|---|---|
| desktop | http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/ |
| Device | URL |
|---|---|
| mobile | http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/ |
Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo
jonataspinto
approved these changes
Mar 3, 2022
Member
jonataspinto
left a comment
jonataspinto
left a comment
There was a problem hiding this comment.
Boa! Só ficou uma coisa para corrigir mas vou deixar o approve já
Member
|
@joaoprferreira caiu bastante o score |
Member
Author
|
Estava dando uma investigada relacionado ao score, e realizei uns testes.
Retirei algumas imagens e fui acompanhando o score, a que mais elevou o score foi quando removi o background do header
|
Signed-off-by: João Pedro <joaof082@gmail.com>
Member
Lighthouse result for https://www.estartandodevs.com.br/
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
|
jonataspinto
reviewed
Mar 3, 2022
Member
jonataspinto
left a comment
jonataspinto
left a comment
There was a problem hiding this comment.
| Device | URL |
|---|---|
| desktop | http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/ |
| Device | URL |
|---|---|
| mobile | http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/ |
Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket | Mocks
Description
eu fiz componente de Perfil do aluno
Provide a description of what was changed and why it was implemented this way.
Testing
Steps
Screenshots / Videos
Add any relevant screenshots or videos. Any video should be added to the Jira ticket and linked here.
Developer Checks