Skip to content

refact: fixing text#67

Merged
jonataspinto merged 2 commits intodevelopfrom
fix/student-profile
Mar 5, 2022
Merged

refact: fixing text#67
jonataspinto merged 2 commits intodevelopfrom
fix/student-profile

Conversation

@joaoprferreira
Copy link
Copy Markdown
Member

@joaoprferreira joaoprferreira commented Mar 5, 2022

Signed-off-by: João Pedro joaof082@gmail.com

Ticket | Mocks

Description

consertando uma palavra que estava errada no perfil do aluno.

Screenshots / Videos

image

image

Add any relevant screenshots or videos. Any video should be added to the Jira ticket and linked here.

Developer Checks

  • PR title & commits adhere to Conventional Commit Specification
  • PR is targeting correct branch, is up-to-date, & no merge conflicts
  • Tested on browser device
  • Tested on Mobile device

Signed-off-by: João Pedro <joaof082@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 5, 2022

✔️ Deploy Preview for dev-estartandodevs ready!

🔨 Explore the source changes: 512ccc7

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-estartandodevs/deploys/6222efe3f53cbf0007e95068

😎 Browse the preview: https://deploy-preview-67--dev-estartandodevs.netlify.app/

@Brenont
Copy link
Copy Markdown
Member

Brenont commented Mar 5, 2022

LGTM 👍

@jonataspinto
Copy link
Copy Markdown
Member

Gooooood

@jonataspinto jonataspinto merged commit 49130ac into develop Mar 5, 2022
@jonataspinto jonataspinto deleted the fix/student-profile branch March 5, 2022 05:07
@jonataspinto
Copy link
Copy Markdown
Member

Lighthouse result for https://www.estartandodevs.com.br/
Metric Score
Performance 0.74
First Contentful Paint 3.0 s
Time to Interactive 4.6 s
Speed Index 3.0 s
Total Blocking Time 490 ms
Largest Contentful Paint 3.6 s
Cumulative Layout Shift 0
Lighthouse result for http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/
Metric Score
Performance 0.92
First Contentful Paint 1.7 s
Time to Interactive 5.1 s
Speed Index 3.0 s
Total Blocking Time 290 ms
Largest Contentful Paint 1.7 s
Cumulative Layout Shift 0.056

Copy link
Copy Markdown
Member

@jonataspinto jonataspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Device URL
mobile http://estartandodevs-site.s3-website-sa-east-1.amazonaws.com/

Not what you expected? Are your scores flaky? Run Lighthouse on Foo
If scores continue to be inconsistent consider running all audits on Foo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants