Fix flaky bigdecimal test by using delta expectations.#178
Merged
Conversation
estebanz01
force-pushed
the
fix-flaky-bigdecimal-test
branch
from
51d4f7d to
5dda37b
Compare
shamangeorge
previously approved these changes
Jul 26, 2025
Due to the nature of the approximations, we need to have a tolerance of error when checking `bigdecimal`s, so we fix this flaky test by using a delta comparison with an error precision of 1e-4.
estebanz01
force-pushed
the
fix-flaky-bigdecimal-test
branch
from
5dda37b to
011e288
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to the nature of the approximations, we need to have a tolerance of error when checking
bigdecimals, so we fix this flaky test by using a delta comparison with an error precision of 1e-4.Related PRs