Support for defaults when destructuring parameters#297
Support for defaults when destructuring parameters#297michaelficarra merged 1 commit intoestools:masterfrom
Conversation
|
Great work on this @tswaters! Do you know how long this will be before we see a new 1.8.x release with this included? Could really use this. |
|
I'm not sure... I'm not a contributer to escodegen... just noticed a problem and created a pull request. |
|
Sorry, I've been meaning to review this for a while now. I'll get to it (and if all's good, make a release) ASAP. |
|
I'm using Istanbul (which uses escodegen) and i've got the same problem with destructuring... Will this pull-requests be merged soon? |
| if (value.type === 'AssignmentPattern') { | ||
| result.push(this.AssignmentPattern(value, Precedence.Sequence, E_TTT)); | ||
| } | ||
| else { |
There was a problem hiding this comment.
I don't like this style, but I'm not going to let it block merging this PR.
edit: 932847d
|
LGTM. Sorry for taking this long to review. |
|
Now this is merged, can you publish a new 1.8.x release to npm? |
|
Published |
|
Nice work. Thanks! |
|
Thanks a lot! |
4 participants
Fixes #296