proto string => bytes WIP #2354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update all string protobuf fields which use casttype `encoding/json.RawMessage` to instead be bytes. This is a correctness issue, and is required for correct processing semantics in later Go gRPC library versions. The decoder must be able to assume that a cast of []byte to a string field allows the []byte to be re-used post-cast, and the use of json.RawMessage breaks this assumption. It's also a performance concern, because `prost` in Rust is able to use zero-copy bytes::Bytes to back a `bytes` field, while String _must_ be deeply cloned.
Update post-processing of generated protobuf serde implementations to account for new bytes::Bytes underlying type.
Various mechanical updates to Rust crates to account for the String => bytes::Bytes conversion of affected fields.
jgraettinger
force-pushed
the
johnny/proto-bytes
branch
from
21c7da8 to
16027b6
Compare
psFried
approved these changes
Aug 21, 2025
| doc_json, | ||
| exists: meta.front(), | ||
| key_json: String::new(), // TODO(johnny) | ||
| key_json: bytes::Bytes::new(), // TODO(johnny) |
Member
There was a problem hiding this comment.
nit: do you remember what these TODOs were for? Remove em?
Member
Author
There was a problem hiding this comment.
They're for plumbing in a json encoding (array) of the key, for connectors that prefer to work with JSON instead of packed foundation-DB tuples. Obviously hasn't been super important, but may be if we start to support user-implemented connectors.
Alex-Bair
added a commit
to estuary/airbyte
that referenced
this pull request
Sep 19, 2025
Updates ATF to the latest protocol changes introduced in estuary/flow#2354.
Alex-Bair
added a commit
to estuary/airbyte
that referenced
this pull request
Sep 19, 2025
Updates ATF to the latest protocol changes introduced in estuary/flow#2354.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all string protobuf fields which use casttype
encoding/json.RawMessageto instead be bytes.This is a correctness issue, and is required for correct processing
semantics in later Go gRPC library versions. The decoder must be able to
assume that a cast of []byte to a string field allows the []byte to be
re-used post-cast, and the use of json.RawMessage breaks this
assumption.
It's also a performance concern, because
prostin Rust is able touse zero-copy bytes::Bytes to back a
bytesfield, while String mustbe deeply cloned.
No semantic or wire changes to the protocol -- this is just a low-level refactor of the in-memory type representation.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is