Revert nodejs to v14 LTS release#245
Merged
Merged
Conversation
snowzach
changed the title
jgraettinger
approved these changes
Sep 23, 2021
Member
jgraettinger
left a comment
jgraettinger
left a comment
There was a problem hiding this comment.
LGTM. Merging now because this also seems to fix an npm permission issue seen w/ connector tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of this issue with Docker For Mac docker/for-mac#5831
Using the flowctl.sh script does not work on M1 Macs when it is using Node 16. This PR reverts back to Node V14 which is the LTS release anyhow and does include the nullish collating operator which I understand was the main driver for upgrading Node.
It also adds a command option to ensure the flow docker image is up to date as part of the
flowctl.shscript.This change is