capture/materialize: in-process drivers must deep copy specifications#248
Merged
Conversation
MaterializationSpec is shared with the catalog KeySpace and must be copied. Audit and document this restriction in drivers. Issue #247
Member
Author
|
Merging because this is a small, scoped change that fixes an active bug. Please leave feedback and I'll address as a follow-up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaterializationSpec is shared with the catalog KeySpace and must be copied.
Audit and document this restriction in drivers.
Tested:
flowctl developcatalog having a built-in Snowflake materializationflowctl shard splitwhile that catalog was running (1 -> 2 shards).materialize-snowflakeconnector.flowctl shard split2x while that catalog was running (2 -> 4 shards).Issue #247
This change is