Remove mention of service accounts in the data plane dialog #2827
Merged
GregorShear merged 1 commit intomasterfrom Apr 3, 2026
Merged
Remove mention of service accounts in the data plane dialog #2827GregorShear merged 1 commit intomasterfrom
GregorShear merged 1 commit intomasterfrom
Conversation
…being removed in favor of the new storage mapping flow)
|
🚀 Preview deployed to https://docs.estuary.dev/pr-preview/pr-2827/ 📄 Changed pages: |
aeluce
approved these changes
Apr 3, 2026
Collaborator
aeluce
left a comment
aeluce
left a comment
There was a problem hiding this comment.
LGTM.
Also FYI @jwhartley the link preview action didn't manage to construct the full slug: /installation should be /getting-started/installation.
2 tasks
jwhartley
added a commit
that referenced
this pull request
Apr 7, 2026
Docusaurus resolves relative slugs (no leading /) from the file's directory. e.g. `slug: installation` in getting-started/installation.md becomes /getting-started/installation, not /installation. The preview link script was prepending / directly, producing the wrong URL for files with relative slugs. Caught on #2827.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service account IDs are being removed from the dataplane dialog in favor of the new storage mapping flow