Skip to content

Switch connectors over to using GQL#1949

Open
travjenkins wants to merge 32 commits intomainfrom
travjenkins/gql/connectors_v2
Open

Switch connectors over to using GQL#1949
travjenkins wants to merge 32 commits intomainfrom
travjenkins/gql/connectors_v2

Conversation

@travjenkins
Copy link
Copy Markdown
Member

@travjenkins travjenkins commented Apr 3, 2026

Issues

#1929

Changes

issue_number

  • We now fetch all of the connector details from GQL on load of edit/create and the admin section (test page still uses PostgREST). This means we stop making extra calls for one offs like resource schema. This is the new useConnectorTag context.
  • More forceful with checking that connectors are valid. The GQL endpoint requires a lot more info so the UI should be good to trust the responses more. This impacts things like the "valid connector" wrapper and the hasValidConnectors hook we used to need.
  • test/jsonforms is now available in production
  • No longer tracking unsupportedConnector as we just fired an event for that and didn't show anything to the user.
  • Cleaned up the old details hydrator as only the test page was using that

Tests

Manually tested

  • scenarios you manually tested

Automated tests

  • unit testing covered

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

Edit now shows the connector image tag in the URL
image

@travjenkins travjenkins mentioned this pull request Apr 6, 2026
6 tasks
setDraftId(null);
setInitiateDiscovery(true);
}, [setDraftId, setInitiateDiscovery, imageTag]);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we prevented users from changing the connector awhile ago I think this is totally safe to remove.

Comment on lines +70 to +75
const q = searchQuery.toLowerCase();
return nodes.filter(
(node) =>
node.title?.toLowerCase().includes(q) ||
node.shortDescription?.toLowerCase().includes(q)
);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now need to do some of the filtering client side.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to need to set stuff here but seems it is good now.

Only thing to call out is the setConnector used to have a side effect of setting setEntityNameChanged. I think Kiahna is right and this was back when the connector could change and we needed to set the name changed because the connector being suffixed was going to change.

Adding basic eventing in
Handling exceptions
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connector folks could use the jsonforms test page in prod.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New basic guard for support role. Potentially we'l add a special error or something here but not major concern right now.

);

export const MAC_ADDR_RE = new RegExp(/^([0-9A-F]{2}:){7}([0-9A-F]{2})$/i);
export const MAC_ADDR_LIKE_RE = new RegExp(/^([0-9A-F]{2}){7}([0-9A-F]{2})$/i);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GQL returns UUIDs without the colon vs Postgrest that returns the UUIDs with colons.

@travjenkins travjenkins added the change:planned This is a planned change label Apr 10, 2026
@travjenkins travjenkins marked this pull request as ready for review April 10, 2026 18:03
@travjenkins travjenkins requested a review from a team as a code owner April 10, 2026 18:03
@travjenkins travjenkins changed the title Travjenkins/gql/connectors v2 Switch connectors over to using GQL Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:planned This is a planned change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant