Add local and utc popper to logs#1970
Merged
Merged
Conversation
travjenkins
commented
May 8, 2026
Comment on lines
+33
to
+38
| <Chip | ||
| sx={BaseTypographySx} | ||
| label={formattedDateTime} | ||
| size="small" | ||
| variant="outlined" | ||
| /> |
Member
Author
There was a problem hiding this comment.
Switch to chip to maybe drive people to view timestamp as interactable
travjenkins
commented
May 8, 2026
| {showRelative ? ( | ||
| <> | ||
| <Divider sx={{ gridColumn: '1 / -1', my: 0.5 }} /> | ||
| <Typography component="dt" /> |
Member
Author
There was a problem hiding this comment.
This isn't perfect - but makes this line sliiiiightly more semantic
local and utc popper to logs
kiahna-tucker
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
#1969
Changes
1969
Tests
Manually tested
Automated tests
Playwright tests ran locally
Screenshots