-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Update 3.6 changelog to cover the membership validation update #19708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 55 files with indirect coverage changes @@ Coverage Diff @@
## main #19708 +/- ##
==========================================
+ Coverage 65.98% 68.60% +2.62%
==========================================
Files 421 418 -3
Lines 35857 35722 -135
==========================================
+ Hits 23659 24508 +849
+ Misses 10791 9766 -1025
- Partials 1407 1448 +41 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ivanvc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @ahrtr.
|
cc @fuweid |
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
|
/test pull-etcd-integration-1-cpu-arm64 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jmhbnz, I'm out next week. Would you be able to help with this release? Otherwise, I can do the release on Monday, April 14th. Thanks :) |
No worries. April 14th+ works. Thanks |
Link to #19703 , which is backport of #19694
I will also add the verification in release-3.6 as mentioned in #19694 (comment)
After that, we should be ready to release
v3.6.0-rc.4.cc @ivanvc @jmhbnz @serathius