Skip to content

Conversation

@serathius
Copy link
Member

In Antithesis we don't have control of failure injection. So we don't have guarantee that the first request will pass.

Changing first request to read fixes the issue of first request not being retryable. Changing the test name prefix to "singleton_driver_" enables antithesis fault injection.

/cc @siyuanfoundation @fuweid @nwnt @henrybear327

@k8s-ci-robot
Copy link

@serathius: GitHub didn't allow me to request PR reviews from the following users: nwnt.

Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

In Antithesis we don't have control of failure injection. So we don't have guarantee that the first request will pass.

Changing first request to read fixes the issue of first request not being retryable. Changing the test name prefix to "singleton_driver_" enables antithesis fault injection.

/cc @siyuanfoundation @fuweid @nwnt @henrybear327

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…in Antithesis

In Antithesis we don't have control of failure injection. So we don't
have guarantee that the first request will pass.

Changing first request to read fixes the issue of first request not being retryable.
Changing the test name prefix to "singleton_driver_" enables antithesis
fault injection.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Copy link
Member Author

Needed to fix tests

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (b6de745) to head (80b550f).
Report is 2 commits behind head on main.

Additional details and impacted files

see 43 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19892      +/-   ##
==========================================
+ Coverage   67.64%   68.84%   +1.19%     
==========================================
  Files         409      424      +15     
  Lines       35452    35878     +426     
==========================================
+ Hits        23981    24699     +718     
+ Misses      10075     9759     -316     
- Partials     1396     1420      +24     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6de745...80b550f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius serathius merged commit 4a8827b into etcd-io:main May 8, 2025
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants