Skip to content

Conversation

@subrajeet-maharana
Copy link
Contributor

Fixes #19885

@k8s-ci-robot
Copy link

Hi @subrajeet-maharana. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joshjms
Copy link
Member

joshjms commented May 9, 2025

Please squash the commits

@serathius
Copy link
Member

Please fix DCO

@subrajeet-maharana subrajeet-maharana force-pushed the antithesis-always-assertion branch from 6c30967 to c5d2215 Compare May 9, 2025 10:06
Signed-off-by: subrajeet-maharana <subrajeet.info@gmail.com>

Update tests/antithesis/test-template/robustness/main.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>

Update tests/antithesis/test-template/robustness/main.go

Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com>
Signed-off-by: subrajeet-maharana <subrajeet.info@gmail.com>
@subrajeet-maharana subrajeet-maharana force-pushed the antithesis-always-assertion branch from c5d2215 to be39678 Compare May 9, 2025 10:37
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, subrajeet-maharana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member

/ok-to-test

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (03177c1) to head (be39678).
Report is 2 commits behind head on main.

Additional details and impacted files

see 47 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19898      +/-   ##
==========================================
+ Coverage   67.60%   68.80%   +1.20%     
==========================================
  Files         424      424              
  Lines       35878    35878              
==========================================
+ Hits        24254    24686     +432     
+ Misses      10200     9761     -439     
- Partials     1424     1431       +7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03177c1...be39678. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k8s-ci-robot
Copy link

@subrajeet-maharana: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-e2e-386 be39678 link true /test pull-etcd-e2e-386

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius serathius merged commit 4976738 into etcd-io:main May 9, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

[Antithesis] Use Always assertion instead of Reachable/Unreachable

4 participants