-
Notifications
You must be signed in to change notification settings - Fork 10.3k
antithesis: replaced Reachable/Unreachable assertion with Always #19898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
antithesis: replaced Reachable/Unreachable assertion with Always #19898
Conversation
|
Hi @subrajeet-maharana. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Please squash the commits |
|
Please fix DCO |
6c30967 to
c5d2215
Compare
Signed-off-by: subrajeet-maharana <subrajeet.info@gmail.com> Update tests/antithesis/test-template/robustness/main.go Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com> Update tests/antithesis/test-template/robustness/main.go Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com> Signed-off-by: subrajeet-maharana <subrajeet.info@gmail.com>
c5d2215 to
be39678
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius, subrajeet-maharana The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 47 files with indirect coverage changes @@ Coverage Diff @@
## main #19898 +/- ##
==========================================
+ Coverage 67.60% 68.80% +1.20%
==========================================
Files 424 424
Lines 35878 35878
==========================================
+ Hits 24254 24686 +432
+ Misses 10200 9761 -439
- Partials 1424 1431 +7 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@subrajeet-maharana: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes #19885