Skip to content

Conversation

@ronaldngounou
Copy link
Member

Overview

This PR addresses the issue #1012
The v3.6 documentation on the website still indicates that it is a draft, and v3.5 remains the default when clicking on the Documentation menu item at the top (etcd.io/docs/latest).

Changes:

  • Modify latest_stable_version parameter to point to v3.6
  • Drop v3.6.0-alpha.0 and the -DRAFT suffixes

to v3.6

Signed-off-by: Ronald Ngounou <74538524+ronaldngounou@users.noreply.github.com>
from the version number in the config.yaml file.

Signed-off-by: Ronald Ngounou <74538524+ronaldngounou@users.noreply.github.com>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ronaldngounou
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @ronaldngounou. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Ronald Ngounou <74538524+ronaldngounou@users.noreply.github.com>
Signed-off-by: Ronald Ngounou <74538524+ronaldngounou@users.noreply.github.com>
@ivanvc
Copy link
Member

ivanvc commented Jun 4, 2025

Thanks for your pull request, @ronaldngounou. Due to the copy of the files, it's massive, and there's no way the linter will have a clean run.

Could we split this pull request into two separate ones? One of the first two commits and another of the other two?

@ronaldngounou
Copy link
Member Author

ronaldngounou commented Jun 4, 2025

Thanks @ivanvc. This PR has been broken in two separate PRs.

  1. Fix latest_stable_version and -alpha.0 and the -DRAFT suffixes #1018
  2. Recursively copy the contents of v3.6 to v3.7 #1019

We can close this one.

@ivanvc
Copy link
Member

ivanvc commented Jun 4, 2025

Thanks, @ronaldngounou :)

/close

@ivanvc ivanvc closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants