Skip to content

Conversation

@ronaldngounou
Copy link
Member

Approach

This PR attemps to fix issue #837 .

I added a section explaining how to embed the Golang embed package. The two sections were added both in v3.5 and v3.6.

Testing

npm run serve
image

@k8s-ci-robot
Copy link

Hi @ronaldngounou. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing this @ronaldngounou. Some minor feedback below.

I think it's ok to just link through to the go docs for now but in future it would be good to iterate on this page with a more thorough write-up.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ronaldngounou - Now we just need to squash your commits as these changes should only be one single commit and ensure that commit is signed so we can accept your contribution, i.e.

git reset --soft HEAD~12
git commit --signoff -a -m "Add section Embedding etcd in a Go Application."
git push --force-with-lease

Signed-off-by: Ronald Ngounou <74538524+ronaldngounou@users.noreply.github.com>
@ronaldngounou
Copy link
Member Author

ronaldngounou commented Apr 22, 2025

The commands you sent were very helpful to unstuck me with git commands, that's why I haven't pushed my changes.

It should work now.

Thanks @jmhbnz !

@jmhbnz
Copy link
Member

jmhbnz commented Apr 22, 2025

/ok-to-test

@jmhbnz
Copy link
Member

jmhbnz commented Apr 30, 2025

Hey @ronaldngounou - Please refer to test failure https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_website/979/pull-website-lint/1914522118930829312. There are some lint errors that need to be addressed before we can merge this thanks! 🙏🏻

@ronaldngounou
Copy link
Member Author

ronaldngounou commented May 1, 2025

I will take a look today.
Update: Done

Signed-off-by: Ronald Ngounou <74538524+ronaldngounou@users.noreply.github.com>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ronaldngounou

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, ronaldngounou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit c53b728 into etcd-io:main May 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants