-
Notifications
You must be signed in to change notification settings - Fork 330
Add section Embedding etcd in a Go Application #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @ronaldngounou. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
26a69ce to
e474c98
Compare
jmhbnz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for proposing this @ronaldngounou. Some minor feedback below.
I think it's ok to just link through to the go docs for now but in future it would be good to iterate on this page with a more thorough write-up.
jmhbnz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ronaldngounou - Now we just need to squash your commits as these changes should only be one single commit and ensure that commit is signed so we can accept your contribution, i.e.
git reset --soft HEAD~12
git commit --signoff -a -m "Add section Embedding etcd in a Go Application."
git push --force-with-leaseSigned-off-by: Ronald Ngounou <74538524+ronaldngounou@users.noreply.github.com>
2cede67 to
ed80d23
Compare
|
The commands you sent were very helpful to unstuck me with git commands, that's why I haven't pushed my changes. It should work now. Thanks @jmhbnz ! |
|
/ok-to-test |
|
Hey @ronaldngounou - Please refer to test failure https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_website/979/pull-website-lint/1914522118930829312. There are some lint errors that need to be addressed before we can merge this thanks! 🙏🏻 |
|
I will take a look today. |
Signed-off-by: Ronald Ngounou <74538524+ronaldngounou@users.noreply.github.com>
jmhbnz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ronaldngounou
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmhbnz, ronaldngounou The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Approach
This PR attemps to fix issue #837 .
I added a section explaining how to embed the Golang
embedpackage. The two sections were added both in v3.5 and v3.6.Testing
npm run serve
