Feature/add btn install #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KovaSs
reviewed
Aug 31, 2020
| {title} | ||
| </div> | ||
| <div className={css.rightGroup}> | ||
| {btn && btn} |
packages/@react-cli-ui/cli-ui/src/components/Dependencies/ProjectDependencies.tsx
Outdated
Show resolved
Hide resolved
| onChange={onInputChange} | ||
| /> | ||
| <div className={css.wrapper}> | ||
| {!!packages.length && packages.map(el => { |
Collaborator
There was a problem hiding this comment.
Suggested change
| {!!packages.length && packages.map(el => { | |
| {Boolean(packages.length) && packages.map(el => { |
packages/@react-cli-ui/cli-ui/src/modals/DependenciesModal/ItemPackages.tsx
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| return ( | ||
| <div className={`${css.item} ${active === pkg.name ? css.active : ''}`} onClick={() => handleClick(pkg.name)} > |
Collaborator
There was a problem hiding this comment.
Есть жи пакет classnames
const styles = cn(css.item, {
[css.active]: active === pkg.name
}| } | ||
|
|
||
| export default function Dependencies () { | ||
| const { t } = useTranslation('dependencies') |
Collaborator
There was a problem hiding this comment.
Пора бы вынести все состояние в отдельный кастомный хук, а то уже многовато функционала набралось
| ) | ||
| } | ||
|
|
||
| function renderAnimatedDots () { |
Collaborator
There was a problem hiding this comment.
Уже повторение функционала с созданием проекта давайте вынесем в утилиту
KovaSs
reviewed
Aug 31, 2020
packages/@react-cli-ui/cli-ui/src/modals/DependenciesModal/Dependencies.modal.tsx
Show resolved
Hide resolved
…ectDependencies.tsx Co-authored-by: Denis Isaev / Денис Исаев <32105128+KovaSs@users.noreply.github.com>
…mPackages.tsx Co-authored-by: Denis Isaev / Денис Исаев <32105128+KovaSs@users.noreply.github.com>
…endencies.modal.tsx Co-authored-by: Denis Isaev / Денис Исаев <32105128+KovaSs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#153 Add node notification
#130 Add function install dependencies
#152 Add button install dependencies
#133 Create functional delete package.json dependencies (WS)
#132 Add button delete dependencies