Skip to content

new deprecated decorator#1214

Merged
Badiboy merged 3 commits intoeternnoir:masterfrom
SwissCorePy:master
Jun 30, 2021
Merged

new deprecated decorator#1214
Badiboy merged 3 commits intoeternnoir:masterfrom
SwissCorePy:master

Conversation

@SwissCorePy
Copy link
Copy Markdown
Contributor

@SwissCorePy SwissCorePy commented Jun 30, 2021

I think this could be useful in the future :)
Or should we replace the old deprecated decorator?
what du you think?

added a new deprecated decorator to util
whoops warn is not optional
@Badiboy
Copy link
Copy Markdown
Collaborator

Badiboy commented Jun 30, 2021

I propose simply replace the old "deprecated" one. I definitly sure nobody used it.

And better to add some tests for it.

@SwissCorePy
Copy link
Copy Markdown
Contributor Author

ok :)

@SwissCorePy
Copy link
Copy Markdown
Contributor Author

hope this test is ok and work

@Badiboy
Copy link
Copy Markdown
Collaborator

Badiboy commented Jun 30, 2021

Super, thank you.

hope this test is ok and work

I hope too. I did not see anyhing in output, hope it means it works. :)

@Badiboy Badiboy merged commit 484e7fc into eternnoir:master Jun 30, 2021
@SwissCorePy
Copy link
Copy Markdown
Contributor Author

Super, thank you.

hope this test is ok and work

I hope too. I did not see anyhing in output, hope it means it works. :)

the should not be any output. just a message in the logs. but i dont know where the logs are stored to be honest ^^

@SwissCorePy
Copy link
Copy Markdown
Contributor Author

SwissCorePy commented Jun 30, 2021

But i did a test with printing insted logging and it works fine :)
2021-06-30 14 28 07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants