Skip to content

Add option to sync every 30 minutes#179

Merged
tasn merged 3 commits intoetesync:masterfrom
0xedward:master
Jul 2, 2021
Merged

Add option to sync every 30 minutes#179
tasn merged 3 commits intoetesync:masterfrom
0xedward:master

Conversation

@0xedward
Copy link
Copy Markdown
Contributor

@0xedward 0xedward commented Jul 2, 2021

I wanted more granularity between the current existing sync intervals of "Every 15 minutes" and "Every hour". I thought others may want this interval as well.

Here's a few screenshots showing the interval is properly set and retrieved from android.content.ContentResolver (note: period and seconds are both set to 1800 seconds when Every 30 minutes is selected:

I didn't update the strings.xml files for other languages because I didn't want to mess up the translation.

0xedward added 2 commits July 1, 2021 13:01
Add option to sync "Every 30 minutes" to Sync interval menu in AccountSettingsActivity view
@0xedward 0xedward changed the title Add option to set sync interval to "Every 30 minutes" Add option to sync every 30 minutes Jul 2, 2021
@tasn
Copy link
Copy Markdown
Member

tasn commented Jul 2, 2021

Could you please fix all of the translations? Because of how the translation arrays work, they'll all have issues unless you add a 30min variant. I think it's safe enough to just copy the 15min variant in each and change the 15 to 30.

@0xedward
Copy link
Copy Markdown
Contributor Author

0xedward commented Jul 2, 2021

@tasn I added the 30 minute interval in the other strings.xml files 🙂

@tasn tasn merged commit dbf7fdf into etesync:master Jul 2, 2021
@tasn
Copy link
Copy Markdown
Member

tasn commented Jul 2, 2021

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants