ETRun map causes CL_ParseSnapshot error

[ensiform]

Map: (Rename to .pk3)
asdarun1.zip

CL_ParseSnapshot: Invalid size 79 for areamask

The number should always be 32 (sizeof int32_t)

Server is sending this number across which likely means there is a memory corruption somewhere (in server) and the code itself has not changed from vanilla in either client or server.

[tsiren]

Checked that sv_snapshot:c func SV_AddEntitiesVisibleFromPoint

// calculate the visible areas
frame->areabytes = CM_WriteAreaBits( frame->areabits, clientarea );

indeed calculates 79 bytes

[ensiform]

CM_WriteAreaBits unchanged from GPL release ET repo though.

[tsiren]

Related variables within that function

origin: 64.000000 272.000000 137.000000
leafnum 24119, clientarea 0, clientcluster 23483
floodnum: 1, numareas 630

[tsiren]

bytes = ( cm.numAreas + 7 ) >> 3;

This shouldn't return more than 32 so something wrong with the numAreas value 630

[tsiren]

Based on that max value for numAreas is 256

[tsiren]

As mentioned in Discord the official binary differs from the original released sources.

if ( len > sizeof( newSnap.areamask ) ) {
Com_Error( ERR_DROP,"CL_ParseSnapshot: Invalid size %d for areamask.", len );
return;
}

This error string is missing from the released binary. You can verify this by running strings in linux.

[ensiform]

And removing it causes other problems still?

[tsiren]

It loaded the level but crashes shortly after, I could try some more experimenting

[ensiform]

I do not actually have a copy of ET.exe retail release at the moment for some reason so I can't actually confirm if the message is missing from there too. My guess is they added it during the time they added the directory traversal fixes to the code post-release similar to what happened with dirtrav fixes for Q3A, post-Q3 GPL.

[tsiren]

I verified that it's also missing from the Windows version.

[tsiren]

The level loads fine in ETe if I comment out the size check. You can verify this in your Win build also. It crashes when joining a team which happens in vanilla as well.. I assume you need the ETRun mod when joining a team?

[ensiform]

I think suburb told me it should still work without the mod. Need confirmation