fix: separate root provisioning from user shell sessions on Incus#9
Merged
ethannortharc merged 1 commit intomainfrom Mar 10, 2026
Merged
fix: separate root provisioning from user shell sessions on Incus#9ethannortharc merged 1 commit intomainfrom
ethannortharc merged 1 commit intomainfrom
Conversation
exec_cmd always runs as root (needed for provisioning). New exec_as_user method runs interactive sessions as the first non-root user with correct HOME and /workspace CWD. Also fixes NIX_PATH to include channel profile path for nixos-rebuild. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec_as_usertrait method for interactive shell sessionsexec_as_userwith--user <uid> --cwd /workspace --env HOME=...exec_as_userso users log in as themselves, not rootTest plan
cargo test— all 67 tests passdevbox create— nixos-rebuild runs as root successfullydevbox shell— logs in as user, not root🤖 Generated with Claude Code