Consolidate duplicated EVM code in bugc tests#176
Merged
Conversation
Replace duplicated EvmExecutor and createMachineState in bugc/test with imports from @ethdebug/evm: - Remove test/evm/evm-executor.ts (272 lines) - Remove test/examples/machine-adapter.ts (83 lines) - Update test/evm/index.ts to re-export Executor as EvmExecutor from @ethdebug/evm (keeps debug script compatibility) - Update test/examples/runners.ts to import directly from @ethdebug/evm - Add @ethdebug/evm as devDependency, remove now-unused direct @ethereumjs/* devDependencies - Add evm to tsconfig project references
Contributor
|
Member
Author
|
Review (compiler agent): Looks good. Clean consolidation.
No issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes ~355 lines of duplicated EVM executor and machine adapter code from bugc's test directory by importing from @ethdebug/evm instead.
Deleted files:
test/evm/evm-executor.ts— near-identical copy of@ethdebug/evm's Executor classtest/examples/machine-adapter.ts— near-identical copy ofcreateMachineState()Changes:
test/evm/index.tsre-exportsExecutor as EvmExecutorfrom@ethdebug/evm, preserving the name used by debug-*.ts scriptstest/examples/runners.tsimportsExecutorandcreateMachineStatedirectly from@ethdebug/evm@ethdebug/evmas devDependency, removed now-unused direct@ethereumjs/*devDependenciesAll 868 tests pass.