Skip to content

docs: re-record demo without Bob's leading-space artefact#25

Merged
JohnMcLear merged 1 commit intomainfrom
docs/demo-no-leading-space
May 3, 2026
Merged

docs: re-record demo without Bob's leading-space artefact#25
JohnMcLear merged 1 commit intomainfrom
docs/demo-no-leading-space

Conversation

@JohnMcLear
Copy link
Copy Markdown
Member

Why

The demo that shipped in #24 still showed Bob's Many of us play... sentence visibly indented by one column. Spotted in review: the cleanup that used to strip that leading space was a property of the old mock LLM, not of the plugin itself. Once the demo switched to a real LLM (gemma3:4b), nothing was removing the space, and the visual implied an asymmetry the plugin isn't actually creating ("AI is helping Alice but ignoring Bob").

Fix

Upstream of the AI: drop the leading space from Bob's typed string in _demo-gif/steps-ep_ai_chat.mjs. Alice's Enter already gives a clean line break, so the defensive space was never necessary. Re-record on top of that.

Result

  • Bob's line sits flush against the line-number gutter as intended.
  • Same demo story as docs: document Ollama + record demo against gemma3 #24: gemma3 surgically tightens Alice's sentence (we would love to play more football at playtimewe'd appreciate more football time at playtime), the changed words are AI-purple, the surrounding words stay in Alice's colour, Bob's contribution untouched.
  • GIF 1.1 MB / 9.5 s; PNG 135 KB.

Same mpdecimate=hi=2304:lo=512:frac=0.05,setpts=N/FRAME_RATE/TB,…,tpad=stop_duration=2.5:stop_mode=clone trim filter as the previous PR's final commit.

🤖 Generated with Claude Code

The take that landed in PR #24 still showed Bob's "Many of us play..."
sentence visibly indented by one column because the steps file typed
it with a literal leading space. The cleanup that used to strip it was
a property of the ep_ai_chat-specific *mock* LLM, not of the plugin —
once the demo switched to a real LLM (gemma3:4b), nothing was
removing the space, and the visual implied an asymmetry the plugin
isn't actually creating.

Fix is upstream of the AI: drop the leading space from Bob's typed
string in steps-ep_ai_chat.mjs (Alice's Enter already gives a clean
line break, so the defensive space was never necessary). Re-record
on top of that.

Result: Bob's line now sits flush against the line-number gutter as
intended, and the rest of the demo's story is unchanged — gemma3
surgically tightens Alice's sentence ("we would love to play more
football at playtime" -> "we'd appreciate more football time at
playtime"), the changed words are AI-purple, the surrounding words
stay in Alice's colour, Bob's contribution is untouched.

GIF 1.1 MB / 9.5 s; PNG 135 KB. Same mpdecimate trim filter chain
as PR #24's final commit.
@qodo-code-review
Copy link
Copy Markdown

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@JohnMcLear JohnMcLear merged commit a4d432d into main May 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant